search

delvtech / hyperdrive

An automated market maker for fixed and variable yield with on-demand terms.
Apache License 2.0
33 stars 4 forks source link

`get_max_short` inaccuracy #603

Closed jalextowle closed 7 months ago

jalextowle commented 1 year ago

As evidenced by this failure: https://github.com/delvtech/hyperdrive/actions/runs/6359494239/job/17272622798?pr=601, our get_max_short function is very off (~60%) in certain edge cases. What may be going on is that we aren't accounting for matured positions in get_max_short. We should apply the updates that will be applied in _applyCheckpoint in the SDK to ensure that the starting share and bond reserves (as well as other accounting variables) are correctly accounted for.

jalextowle commented 1 year ago

Another large failure: https://github.com/delvtech/hyperdrive/actions/runs/6359494239/job/17272622798?pr=601.

jalextowle commented 7 months ago

This issue is stale and has been superseded by newer issues.