delvtech / hyperdrive

An automated market maker for fixed and variable yield with on-demand terms.
Apache License 2.0
26 stars 3 forks source link

Removed unnecessary assignment from the `HyperdriveFactory` #936

Closed jalextowle closed 5 months ago

jalextowle commented 5 months ago

Resolved Issues

Fixes: https://github.com/spearbit-audits/delv-review/issues/19

Description

Removes a few unnecessary assignments from the HyperdriveFactory.

Review Checklists

Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled ## [Reviewer Name]. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.

@mcclurejt

Solidity

github-actions[bot] commented 5 months ago

Hyperdrive Gas Benchmark

Benchmark suite Current: 4555a42ee6ea0a8687f59d8e4bafc727cba5cb77 Previous: 46c834d403754cb2c6c572563bccd65634c54aff Deviation Status
addLiquidity: min 33915 gas 1546 gas 2093.7257% 🚨
addLiquidity: avg 145024 gas 67936 gas 113.4715% 🚨
addLiquidity: max 405253 gas 293159 gas 38.2366% 🚨
checkpoint: min 29232 gas 1182 gas 2373.0964% 🚨
checkpoint: avg 103962 gas 48477 gas 114.4563% 🚨
checkpoint: max 211255 gas 191559 gas 10.2819% 🚨
closeLong: min 31428 gas 1492 gas 2006.4343% 🚨
closeLong: avg 132834 gas 29374 gas 352.2162% 🚨
closeLong: max 299537 gas 152303 gas 96.6718% 🚨
closeShort: min 31349 gas 1494 gas 1998.3266% 🚨
closeShort: avg 127641 gas 33444 gas 281.6559% 🚨
closeShort: max 201614 gas 149156 gas 35.1699% 🚨
initialize: min 31283 gas 1451 gas 2055.9614% 🚨
initialize: avg 252985 gas 213962 gas 18.2383% 🚨
initialize: max 322173 gas 253953 gas 26.8632% 🚨
openLong: min 33503 gas 1499 gas 2135.0233% 🚨
openLong: avg 167134 gas 51658 gas 223.5394% 🚨
openLong: max 252525 gas 185562 gas 36.0866% 🚨
openShort: min 33848 gas 1520 gas 2126.8421% 🚨
openShort: avg 169453 gas 51482 gas 229.1500% 🚨
openShort: max 363609 gas 181325 gas 100.5289% 🚨
redeemWithdrawalShares: min 31227 gas 1488 gas 1998.5887% 🚨
redeemWithdrawalShares: avg 63441 gas 22375 gas 183.5352% 🚨
redeemWithdrawalShares: max 161900 gas 109301 gas 48.1231% 🚨
removeLiquidity: min 31323 gas 1530 gas 1947.2549% 🚨
removeLiquidity: avg 219428 gas 151225 gas 45.1003% 🚨
removeLiquidity: max 376082 gas 325781 gas 15.4401% 🚨

This comment was automatically generated by workflow using github-action-benchmark.