Closed mcclurejt closed 4 months ago
Benchmark suite | Current: 59a3de59cc917e83a00bfddc5b7ce1fd1f78435e | Previous: bd5a941ef7b7c07fe68b3e7f8e4d082ad8e03da9 | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33893 gas |
33893 gas |
0% |
π° |
addLiquidity: avg |
144481 gas |
143746 gas |
0.5113% |
π¨ |
addLiquidity: max |
428319 gas |
428335 gas |
-0.0037% |
β |
checkpoint: min |
40220 gas |
40220 gas |
0% |
π° |
checkpoint: avg |
104060 gas |
104098 gas |
-0.0365% |
β |
checkpoint: max |
212154 gas |
212154 gas |
0% |
π° |
closeLong: min |
31517 gas |
31517 gas |
0% |
π° |
closeLong: avg |
138117 gas |
137990 gas |
0.0920% |
π¨ |
closeLong: max |
2640435 gas |
2640435 gas |
0% |
π° |
closeShort: min |
31394 gas |
31394 gas |
0% |
π° |
closeShort: avg |
132750 gas |
132798 gas |
-0.0361% |
β |
closeShort: max |
227553 gas |
227553 gas |
0% |
π° |
initialize: min |
31305 gas |
31305 gas |
0% |
π° |
initialize: avg |
253630 gas |
253632 gas |
-0.0008% |
β |
initialize: max |
322760 gas |
322760 gas |
0% |
π° |
openLong: min |
33437 gas |
33437 gas |
0% |
π° |
openLong: avg |
167390 gas |
167437 gas |
-0.0281% |
β |
openLong: max |
253162 gas |
253162 gas |
0% |
π° |
openShort: min |
33959 gas |
33959 gas |
0% |
π° |
openShort: avg |
170140 gas |
170211 gas |
-0.0417% |
β |
openShort: max |
385650 gas |
385650 gas |
0% |
π° |
redeemWithdrawalShares: min |
31227 gas |
31227 gas |
0% |
π° |
redeemWithdrawalShares: avg |
62089 gas |
62048 gas |
0.0661% |
π¨ |
redeemWithdrawalShares: max |
167572 gas |
167572 gas |
0% |
π° |
removeLiquidity: min |
31191 gas |
31191 gas |
0% |
π° |
removeLiquidity: avg |
223136 gas |
223552 gas |
-0.1861% |
β |
removeLiquidity: max |
398887 gas |
398887 gas |
0% |
π° |
This comment was automatically generated by workflow using github-action-benchmark.
Resolved Issues
Description
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.[[Reviewer Name]]
Solidity
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?Rust