Closed jrhea closed 4 months ago
Benchmark suite | Current: 826ba907dd5a37672b4d61e5ac5bcc71e9149cf6 | Previous: b3f33e9bb384edecc7f131e8114037e3da4c4780 | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33893 gas |
33893 gas |
0% |
π° |
addLiquidity: avg |
144624 gas |
144699 gas |
-0.0518% |
β |
addLiquidity: max |
428335 gas |
428319 gas |
0.0037% |
π¨ |
checkpoint: min |
40220 gas |
40220 gas |
0% |
π° |
checkpoint: avg |
104118 gas |
104021 gas |
0.0933% |
π¨ |
checkpoint: max |
212154 gas |
212154 gas |
0% |
π° |
closeLong: min |
31517 gas |
31517 gas |
0% |
π° |
closeLong: avg |
138082 gas |
137987 gas |
0.0688% |
π¨ |
closeLong: max |
2640435 gas |
2640435 gas |
0% |
π° |
closeShort: min |
31394 gas |
31394 gas |
0% |
π° |
closeShort: avg |
132801 gas |
132925 gas |
-0.0933% |
β |
closeShort: max |
227565 gas |
227565 gas |
0% |
π° |
initialize: min |
31305 gas |
31305 gas |
0% |
π° |
initialize: avg |
253630 gas |
253633 gas |
-0.0012% |
β |
initialize: max |
322760 gas |
322760 gas |
0% |
π° |
openLong: min |
33437 gas |
33437 gas |
0% |
π° |
openLong: avg |
167135 gas |
167174 gas |
-0.0233% |
β |
openLong: max |
253162 gas |
253162 gas |
0% |
π° |
openShort: min |
33959 gas |
33959 gas |
0% |
π° |
openShort: avg |
170455 gas |
170339 gas |
0.0681% |
π¨ |
openShort: max |
385650 gas |
385650 gas |
0% |
π° |
redeemWithdrawalShares: min |
31227 gas |
31227 gas |
0% |
π° |
redeemWithdrawalShares: avg |
61993 gas |
62010 gas |
-0.0274% |
β |
redeemWithdrawalShares: max |
167572 gas |
167572 gas |
0% |
π° |
removeLiquidity: min |
31191 gas |
31191 gas |
0% |
π° |
removeLiquidity: avg |
223199 gas |
223379 gas |
-0.0806% |
β |
removeLiquidity: max |
398887 gas |
398887 gas |
0% |
π° |
This comment was automatically generated by workflow using github-action-benchmark.
Description
I had 3 options to test
IERC20ForwarderFactory.InvalidForwarderAddress
revert:1) add a zero address check to the revert in
ERC20ForwarderFactory.create()
2) remove that revert altogether 3) add a virtual keyword toERC20ForwarderFactory.getForwarder()
so it could be tested as-is.I chose option 3. I'm curious if y'all see a better way. Here are the details of the cleanup made to the tests and the increased coverage:
ERC20ForwarderFactory.getForwarder()
so failure case could be testedtestERC20ForwarderFactoryInvalidForwarderAddress()
@jalextowle
[ ] Testing
[ ] Are there an adequate number of fuzz tests to ensure that we are covering the full input space?
@mcclurejt
[ ] Testing