delvtech / hyperdrive

An automated market maker for fixed and variable yield with on-demand terms.
Apache License 2.0
28 stars 3 forks source link

Tweaked the tests to improve coverage #983

Closed jalextowle closed 5 months ago

jalextowle commented 5 months ago

Description

Added coverage to the InstanceTest suite.

Review Checklists

Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled ## [Reviewer Name]. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.

@jrhea

Solidity

@mcclurejt

Solidity

github-actions[bot] commented 5 months ago

Hyperdrive Gas Benchmark

Benchmark suite Current: 885105ea1d33730a37191c8368cd7d2d773d3e0e Previous: dada2f960df0457e64eb6116e98595cb1f62c48e Deviation Status
addLiquidity: min 33893 gas 33893 gas 0% 🟰
addLiquidity: avg 144587 gas 144301 gas 0.1982% 🚨
addLiquidity: max 428295 gas 428319 gas -0.0056% βœ…
checkpoint: min 40220 gas 40220 gas 0% 🟰
checkpoint: avg 103984 gas 104067 gas -0.0798% βœ…
checkpoint: max 212154 gas 212154 gas 0% 🟰
closeLong: min 31517 gas 31517 gas 0% 🟰
closeLong: avg 138171 gas 137774 gas 0.2882% 🚨
closeLong: max 2640435 gas 2640435 gas 0% 🟰
closeShort: min 31394 gas 31394 gas 0% 🟰
closeShort: avg 132750 gas 132727 gas 0.0173% 🚨
closeShort: max 227565 gas 227565 gas 0% 🟰
initialize: min 31305 gas 31305 gas 0% 🟰
initialize: avg 253632 gas 253638 gas -0.0024% βœ…
initialize: max 322760 gas 322760 gas 0% 🟰
openLong: min 33437 gas 33437 gas 0% 🟰
openLong: avg 167181 gas 167331 gas -0.0896% βœ…
openLong: max 253162 gas 253162 gas 0% 🟰
openShort: min 33959 gas 33959 gas 0% 🟰
openShort: avg 170521 gas 170153 gas 0.2163% 🚨
openShort: max 385650 gas 385650 gas 0% 🟰
redeemWithdrawalShares: min 31227 gas 31227 gas 0% 🟰
redeemWithdrawalShares: avg 62273 gas 61916 gas 0.5766% 🚨
redeemWithdrawalShares: max 167572 gas 167572 gas 0% 🟰
removeLiquidity: min 31191 gas 31191 gas 0% 🟰
removeLiquidity: avg 222666 gas 223242 gas -0.2580% βœ…
removeLiquidity: max 398887 gas 398887 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

coveralls commented 5 months ago

Coverage Status

coverage: 93.125% (+0.4%) from 92.76% when pulling 885105ea1d33730a37191c8368cd7d2d773d3e0e on jalextowle/tests/reth-code-coverage into 79a049e4f1331b594218f881e88265a7c80557e7 on main.