delwen / screenit-tool-comparison

0 stars 0 forks source link

Descriptive analysis report #1

Closed elisabascunan closed 10 months ago

elisabascunan commented 10 months ago

This pull request will add to main the files associated with the descriptive analysis report:

Finally, it also adds a new dataset to the folder testing (regset.csv). This file contains the data to run the file descriptive-analysis.qmd

delwen commented 10 months ago

Thanks @elisabascunan! Looks good. Regarding where to store data: I recommend creating a data folder to store both completed extraction sheets (both the nc_man_check.csv and reg_set_man_check.csv files). However, I also suggest to then ignore this folder in git. This means that this data folder exists locally, but doesn't get pushed to remote. It should just be a matter of creating the new folder, moving the files there, and then adding the folder data/ in your .gitignore file (and then commit these changes). If you do this, you'll also have to change the path in your qmd where you read in the reg_set_man_check.

You can then share the two extraction sheets as CSV to others through other means so that they have it locally and be able to reproduce the analysis. We may revert on this decision and push everything to the remote, but TBD.

Thanks, great job!

elisabascunan commented 10 months ago

Hi Delwen, I created the new folder and added/moved the extraction sheets there. I also modified the code on the qmd with the new path to this folder.

With regards to your last point (adding the folder data/ in your .gitignore file), I see that on line 6 "data/" is already on the .gitignore file:

Screenshot 2023-12-11 at 11 50 37

I am not sure if that it is all that is needed to effectively add the folder on the .gitignore file. If that is sufficient, then the changes are completed for the pull request.

elisabascunan commented 10 months ago

The data folder with the extraction sheets was eliminated from the repository. The test_branch should be ready to merge.