delwen / screenit-tool-comparison

0 stars 0 forks source link

Pull request: SciScore additional analysis #5

Open elisabascunan opened 3 months ago

elisabascunan commented 3 months ago

For SciScore analysis, there are two new tables with:

Additionally, the titles of the location ID per tool plots were modified, elimintating the phrase "detected by toolname"

delwen commented 3 months ago

@elisabascunan see below some additional changes needed to the dataset. Please review the corrections again before incorporating them as a sanity check. I think the easiest is if you make these changes in the Google Sheet, and then read in the updated dataset in your analysis workflow. That way the changes will be integrated everywhere (but please push back on this if you're seeing an issue I overlooked!).

  1. Rename "TrialIdentifier" to "TRNscreener" in line with the updates in the main paper.

  2. NCT0002523: when I looked into some of the IDs/papers that were not detected by SciScore, I saw that this ID is in the results section of the paper (and not in the methods as indicated in the extraction form), so we should correct this in the extraction form and analysis.

  3. NCT00418041: this was also detected in the notes/metadata of the article. We could potentially reflect this by setting id_in_other_location to TRUE (+ comment), unless you didn't typically consider metadata?

  4. NCT01768585: right now, we have two entries for this trial ID (NCT01768585 and NCT 01768585) for the same paper (PMC8024658). We decided that we will collapse these, since we only have a second row for this ID because ctregistries is cleaning the detected identifier. In reality, the ID as written in the paper was found by TrialIdentifier (or TRNscreener), ctregistries, and NCT naive tool. So concretely, you can merge these two rows and keep as Identifier "NCT01768585" and set sciscore_hit to FALSE, and trialidentifier_hit (or trnscreener_hit), ctregistries_hit, and nct_hit to TRUE. Ideally add a comment explaining that these two entries were merged so we can keep track. Note that this resolves one of the questions we had in this issue: https://github.com/delwen/screenit-tool-comparison/issues/2#issuecomment-1976881390.

  5. Once these changes are made, re-generate the analysis.

Thanks, and let me know if this raises any questions!

elisabascunan commented 3 months ago

@delwen thank you for the feedback! I made the changes on the dataset and updated the file regset.csv accordingly. I also commited the newest version of the quarto report with the correct numbers. Let me know if you need me to add anything else.

elisabascunan commented 1 month ago

HI @delwen

I just went through most of the comments and I only have my doubts with the last one regarding shorter NCTs (stated above as a reply). To answer the main questions of this review:

Screenshot 2024-05-30 at 09 26 07

I will wait for your comments before pushing the new version. Thank you in advance!