search

demantz / RFAnalyzer

Spectrum Analyzer for Android using the HackRF
GNU General Public License v2.0
869 stars 206 forks source link

App Title & Icon Not Displayed In Top Left Corner, Inconsistent with Material Design #19

Closed bmccoy11 closed 9 years ago

bmccoy11 commented 9 years ago

Hello again,

The app title and icon isn't displayed in the top left corner, which is inconsistent with other Material apps and the app would look nicer with it.

demantz commented 9 years ago

Thx for this bug report too ;) I also fixed it in the alpha (1.13alpha3): https://github.com/demantz/RFAnalyzer/blob/scan_feature/RFAnalyzer.apk?raw=true

Could you confirm that this version acts as you would expect it?

Cheers, Dennis

bmccoy11 commented 9 years ago

The icon is still missing in the top left corner.

demantz commented 9 years ago

I think this is the default behavior for material design. Non of the system apps is showing an icon...

bmccoy11 commented 9 years ago

Oh, you're right - the icon shouldn't be in the top left corner, but the overflow menu should be (and it should be a hamburger button/sidebar instead)

demantz commented 9 years ago

You're right. But the sidebar/drawer should contain the app's main menu (like settings and help).. All the other actions (like autoscale) remain in the overflow on the right. I will fix this after all the more important features are implemented. Thanks for the hint ;)