tech: ETQ usager je souhaite une verification de mes mails plus efficace

demarches-simplifiees / demarches-simplifiees.fr

Dématérialiser et simplifier les démarches administratives

https://www.demarches-simplifiees.fr

GNU Affero General Public License v3.0

193 stars 88 forks source link

tech: ETQ usager je souhaite une verification de mes mails plus efficace #10499

Closed mfo closed 3 months ago

mfo commented 3 months ago

fix: https://github.com/demarches-simplifiees/demarches-simplifiees.fr/issues/10418

colinux commented 3 months ago

plop pour info j'avais bricolé un peu de code est surtout la liste des domaines majeurs ici (variable isp_domains ) https://pad.numerique.gouv.fr/0xLhSfMoSMGcLWTaCkcjig?both

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.12%. Comparing base (5ef29a2) to head (39d955e). Report is 38 commits behind head on main.

:exclamation: Current head 39d955e differs from pull request most recent head 8e3d45b

Please upload reports for the commit 8e3d45b to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #10499 +/- ## ========================================== - Coverage 80.89% 75.12% -5.77% ========================================== Files 1211 1213 +2 Lines 25612 26051 +439 Branches 4623 4531 -92 ========================================== - Hits 20719 19572 -1147 - Misses 4893 6479 +1586 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mfo commented 3 months ago

Quelques petites suggestions d'amélioration (à prendre ou à laisser !), mais c'est vraiment trop bien. Aussi on peut donc virer email-butler maintenant

yeap email-butler a été viré ;-) merci pour tes feedback, cf: https://github.com/demarches-simplifiees/demarches-simplifiees.fr/pull/10499/commits/431fa033b4a12b6019d1bf43ef531f3bf7b7bf43

sentry-io[bot] commented 3 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ Mail::Field::IncompleteParseError: Mail::AddressList can not parse |obkrete9@yahoo.com ••••••••|: Only able to parse up to "obkrete9... EmailCheckerController#show View Issue
‼️ Mail::Field::IncompleteParseError: Mail::AddressList can not parse |@orange.fr|: Only able to parse up to "@orange.fr" (Mail::Field:... EmailCheckerController#show View Issue

_{Did you find this useful? React with a 👍 or 👎}