demental / wp-deploy-flow

A wp-cli command to deploy your wordpress instance.
82 stars 15 forks source link

Added support for alternative ssh ports #6

Closed nubz closed 11 years ago

nubz commented 11 years ago

I had a need to use a port number other than 22 for my deployment, I have edited this to support the use of STAGING_SSH_PORT, PROD_SSH_PORT etc in WP-config.php

demental commented 11 years ago

Nice feature, apart from the small enhancement requested in my last comment !

nubz commented 11 years ago

the quotes are required for rsync ssh but not for the constant e.g. define('STAGING_SSH_PORT', 223); works just fine - perhaps some typecasting would help

EDIT - I see its my use of the escapeshellarg method that's adding the extra quotes, I get no complaint from Ubuntu with the quotes in but can't say how it works elsewhere - how about I don't escapeshellarg it and just intval() instead?