search

demergent-labs / azle

A WebAssembly runtime for TypeScript and JavaScript on ICP
MIT License
189 stars 33 forks source link

add chunking api interface to management canister #1768

Open sudoshreyansh opened 1 month ago

lastmjs commented 4 weeks ago

Please follow these instructions: https://github.com/demergent-labs/azle?tab=readme-ov-file#contributing

lastmjs commented 4 weeks ago

If you are able to sign the license extension, I would like to ask for tests to be added to this PR as well. Most of our management canister tests are here: https://github.com/demergent-labs/azle/tree/main/examples/management_canister

You would need to add whatever extra functionality you've added to the management canister to this example similar to the other APIs in there, and add the tests as well.

That's all basic feedback before a thorough review.

sudoshreyansh commented 4 weeks ago

Sure! I have signed the license #1771 I have added the examples and tests. I will also update the Azle book docs and mark this ready for review.

lastmjs commented 4 weeks ago

Great I have merged the license extension signature and am now running the tests. Will review in the next few days.

lastmjs commented 3 weeks ago

I've reviewed everything but the tests themselves, looking good so far just a few basic changes requested.

lastmjs commented 3 weeks ago

I've finished my review, requesting a few changes, very impressed and thanks for the help!

lastmjs commented 3 weeks ago

Actually, there is another problem. You can ignore the other tests, but the bitcoin tests are failing and I don't believe they should be. It probably has something to do with updating the ic.did file. If you could address that so they are passing it would be great.

sudoshreyansh commented 2 weeks ago

Yeah, @lastmjs you were right regarding the bitcoin tests. Fixed it. Also addressed the other requested changes.

sudoshreyansh commented 3 hours ago

Hey, @lastmjs can you re-review when you have time?