search

demerphq / Data-Dump-Streamer

Data::Dump::Streamer - DDS - Accurately serialize a data structure as Perl code.
http://search.cpan.org/dist/Data-Dump-Streamer/
3 stars 11 forks source link

fix for RT#90128 #3

Closed mjgardner closed 10 years ago

mjgardner commented 10 years ago

I "fixed" RT#90128 by removing the offending test, since it relied on JSON::XS::Boolean, which is now deprecated after JSON::XS 3.0 and is now just a wrapper around JSON::PP::Boolean.

eserte commented 10 years ago

See https://github.com/demerphq/Data-Dump-Streamer/pull/5 for an alternative fix. This one does not remove test 7, but determines automatically if JSON::XS::Boolean or JSON::PP::Boolean has to be used.

Regards, Slaven

demerphq commented 10 years ago

Just a heads up... I plan to do a session of DDS merges, and roll a new release soon, probably by end of next weekend.

On 29 December 2013 21:08, Slaven Rezić notifications@github.com wrote:

See #5 https://github.com/demerphq/Data-Dump-Streamer/pull/5 for an alternative fix. This one does not remove test 7, but determines automatically if JSON::XS::Boolean or JSON::PP::Boolean has to be used.

Regards, Slaven

— Reply to this email directly or view it on GitHubhttps://github.com/demerphq/Data-Dump-Streamer/pull/3#issuecomment-31324170 .

perl -Mre=debug -e "/just|another|perl|hacker/"

demerphq commented 10 years ago

I have merged the patch from Slaven to run time determine the appropriate class.