demerphq / Data-Dump-Streamer

Data::Dump::Streamer - DDS - Accurately serialize a data structure as Perl code.
http://search.cpan.org/dist/Data-Dump-Streamer/
3 stars 11 forks source link

Fail with perl 5.16.3 on linux. #8

Closed jeteve closed 10 years ago

jeteve commented 10 years ago

Hi,

Building this fails with perl 5.16.3

see http://www.cpantesters.org/cpan/report/376392de-535c-11e3-a8f2-ae50d605dcb9

I pinned it down to

-Expected +Result @30,30 (30) = };

For test at line 295

For some reason, JSON::XS::decode_json("true"); gives a JSON::PP::Boolean

$ perl -MJSON::XS -MData::Dumper -e 'print Dumper(JSON::XS::decode_json("true"));' $VAR1 = bless( do{(my $o = 1)}, 'JSON::PP::Boolean' );

My JSON::XS version is 3.01

Interesting stuff:

https://metacpan.org/pod/JSON::PP::Boolean#NOTES-FOR-XS-USERS

Filing this for now, more details may follow :)

Cheers,

Jerome.

jeteve commented 10 years ago

This is mentionned here too https://rt.cpan.org/Public/Bug/Display.html?id=90311

demerphq commented 10 years ago

Sorry about this, I have been too busy to roll a new DDS release. Trying to find time to do it soon.

On 6 January 2014 10:19, Jerome Eteve notifications@github.com wrote:

This is mentionned here too https://rt.cpan.org/Public/Bug/Display.html?id=90311

— Reply to this email directly or view it on GitHubhttps://github.com/demerphq/Data-Dump-Streamer/issues/8#issuecomment-31635722 .

perl -Mre=debug -e "/just|another|perl|hacker/"

jeteve commented 10 years ago

What about fixing it by making the test to adapt to whatever sort of class JSON::XS::decode_json("true") returns?

I'm happy doing it.

Cheers.

jeteve commented 10 years ago

Code change is in pull request #9

demerphq commented 10 years ago

IIRC this is done. Thanks for the report and patch.