Closed heliguy4599 closed 9 months ago
That sounds pretty sick! :3
Just saying, but if this gets merged, Am I allowed to submit it to This week in GNOME?
hey @heliguy4599, thanks for the pr! :) I don't have access to my main laptop at the moment, but I'll try to test it as soon as I can. I didn't notice any major issues at first glance, I'll make a comment here when I'm able to test everything.
@AtiusAmy of course, feel free to post it! :) But I suggest waiting until the new version of the extension (v10) with this PR is officially released on the gnome extensions website, so people can actually use the new feature after reading your post.
Alright that's awesome! I look forward to hearing about it. And no problem for the PR, it was a fun task to work on :)
apart from those 2 minor issues everything else is fine :)
@heliguy4599 thanks! :) I'll test everything in a vm as soon as I can.
Awesome! Can't wait!
@heliguy4599 I just tested the updated pr and everything works great! :) thank you!
Yay! And yeah no problem. Happy to help :D
I would like to know why the changes were reverted and are not available in the latest version
I would like to know why the changes were reverted and are not available in the latest version
Maybe because i abandoned the project, im sorry but i really not have the energy for the Linux community rn, just not a fun place to be around...
hey @antos07, the colored icons support never got into the extensions.gnome.org version of the extension because the filesize of the extension with all the extra icon packs was too big, so when the icon pack was discontinued I decided to remove the feature, an older version of the extension with the colored icons support is still in the repo in a separate branch but it's a lot of commits behind the main branch by now.
In issue #22 the feature request to add colored icon support featuring Amy's Adwaita Color's icon pack. This PR adds the support for those to be enabled from your extension. This is acchieved by the following:
resources/<selected color>
directory~/.local/share/icons/
folderorg.gnome.desktop.interface icon-theme: custom-icon-colors
icon themeI've tested this on GNOME 45 via openSUSE Tumbleweed.
I've matched your coding and naming styles so that it should be easy to follow along with what has changed. I'm willing to make any changes you deem necessary and really hope this feature can be added! Thank you for an amazing extension!