demetrisk03 / custom-accent-colors

A GNOME Shell Extension that provides 7 custom accent colors for versions 43-46. The selected accent color can be applied to GTK4/GTK3 apps and the GNOME Shell.
https://extensions.gnome.org/extension/5547/custom-accent-colors
GNU General Public License v3.0
71 stars 12 forks source link

GNOME 47 support #48

Closed radical4ever closed 2 months ago

radical4ever commented 2 months ago

Hi, so in gnome 47 accent colors were introduced, they work to apps with the proper support, but not all of them have it and gtk3 apps cant, it will be cool if the app gets updated to support gnome 47 alongside its default colors, thank you

demetrisk03 commented 2 months ago

you're right, but syncing accent colors between the (recently officially added) accent colors of the gnome-shell and the adw-gtk3 theme, is different from the original goal of the extension, which was to add accent colors to the gnome-shell, so maybe a separate extension needs to be made for the feature you're requesting.

radical4ever commented 2 months ago

Then I guess adding only the colors of the official gnome accents colors to the extension is fine too, I think with only that the extension could be for making adw-gtk3 use the os main accent color, since the theme itself is unable to do that

demetrisk03 commented 2 months ago

I agree, I just don't think that I like the idea of changing the whole purpose of the current extension (as I said above), in the future I might make a new extension with a more appropriate name, for the purpose you're describing above.

radical4ever commented 2 months ago

It's okay, this was a suggestion, but this extension still rocks in 47 since gtk3 accent coloring is impossible if not by this extension

TheRsKing commented 1 month ago

you're right, but syncing accent colors between the (recently officially added) accent colors of the gnome-shell and the adw-gtk3 theme, is different from the original goal of the extension, which was to add accent colors to the gnome-shell, so maybe a separate extension needs to be made for the feature you're requesting.

I would love to see this