Native Task support in F#

demetrixbio / FSharp.Data.Npgsql

F# type providers to support statically typed access to input parameters and result set of sql statement in idiomatic F# way. Data modifications via statically typed tables.

Apache License 2.0

128 stars 15 forks source link

Native Task support in F# #107

Closed TheAngryByrd closed 2 years ago

kerams commented 2 years ago

I believe this was reverted https://github.com/demetrixbio/FSharp.Data.Npgsql/commit/89507aff7892af7f7d2a98540c4c074dad64c891

TheAngryByrd commented 2 years ago

This was reverted according to this issue https://github.com/dotnet/fsharp/issues/12556 @melanore. I've verified the transaction scope using FsToolkit's implementation of taskResult does not have this problem and is related to not using a resumable code implementation.

Please double check this though, there may be edges I'm not aware of from this report.

TheAngryByrd commented 2 years ago

Additionally, I've implemented a resumable version of taskEither in https://github.com/demetrixbio/Plough.ControlFlow/pull/5 based on FsToolkits taskResult.