netcoreapp2.1 in nuspec?

[cartermp]

Hey folks,

We regressed the F# compiler resulting in a regression where FSharp.Data.Npgsql fails to build here: https://github.com/dotnet/fsharp/issues/8832

We'll be adding back in assembly probing for netcoreapp2.0, which was removed because .NET Core 2.0 has been long unsupported.

The fix will align with the VS 16.6 release, but in the interim, if you change the TFM here to a supported runtime (such as netcoreapp3.1), then it should work:

https://github.com/demetrixbio/FSharp.Data.Npgsql/blob/master/src/Runtime/FSharp.Data.Npgsql.nuspec#L25

[daz10000]

Can’t see any problems for us updating that. We generally like to stay pretty current. Would that break for anyone out there ?

Darren

Am 30.03.2020 um 5:25 PM schrieb Phillip Carter notifications@github.com:

 Hey folks,

We regressed the F# compiler resulting in a regression where FSharp.Data.Npgsql fails to build here: dotnet/fsharp#8832

We'll be adding back in assembly probing for netcoreapp2.0, which was removed because .NET Core 2.0 has been long unsupported.

The fix will align with the VS 16.6 release, but in the interim, if you change the TFM here to a supported runtime (such as netcoreapp3.1), then it should work:

https://github.com/demetrixbio/FSharp.Data.Npgsql/blob/master/src/Runtime/FSharp.Data.Npgsql.nuspec#L25

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[cartermp]

My guess is likely not. .NET Core 2.0 went out of support in October of 2018, so I doubt folks are using it by now.

[cartermp]

Additionally, since all supported .NET Core runtimes implement .NET Standard 2.0, the netstandard2.0 binary will always work for them.

[melanore]

Switched to .net standard in https://github.com/demetrixbio/FSharp.Data.Npgsql/pull/80. Version 0.2.5-beta released. Thanks for help!

[cartermp]

Thanks!