search

demetrixbio / FSharp.Data.Npgsql

F# type providers to support statically typed access to input parameters and result set of sql statement in idiomatic F# way. Data modifications via statically typed tables.
Apache License 2.0
127 stars 16 forks source link

Use paket for builds and remove net framework dependency #79

Closed Swoorup closed 4 years ago

Swoorup commented 4 years ago

For future builds can we remove net framework as a dependency? It seems like a lot of pain to get it working on mac and linux.

melanore commented 4 years ago

Type provider was migrated to netstandard2.0 without any net461 dependencies. It works smoothly on Windows/Unix using 3.1.201 SDK.
As for paket, - we plan on migrating at some point in future. As usually, thanks for feedback. MRs are welcome.

Swoorup commented 4 years ago

I have a branch on which i have migrated tests and the actual solution to paket. Let me know if you'd like a PR.

Do you why tests are testing an old package? https://github.com/demetrixbio/FSharp.Data.Npgsql/blob/master/tests/SampleApp/SampleApp.fsproj#L17

kerams commented 4 years ago

That's just a sample app that's not used in integration testing.

daz10000 commented 4 years ago

Happy to look at a PR. Tests are unit tests in tests folder.

Am 04.04.2020 um 2:34 AM schrieb Swoorup Joshi notifications@github.com:

 I have a branch on which i have migrated tests and the actual solution to paket. Let me know if you'd like a PR.

Do you why tests are testing an old package? https://github.com/demetrixbio/FSharp.Data.Npgsql/blob/master/tests/SampleApp/SampleApp.fsproj#L17

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Swoorup commented 4 years ago

Sure, I'll create it once I clean it up a bit.