demhademha / tweak-development-guide

From complete beginner to tweak dev!
GNU General Public License v3.0
118 stars 11 forks source link

Suggestions for the chapter 1 #4

Closed raspberryenvoie closed 3 years ago

raspberryenvoie commented 3 years ago

Hello @demhademha I found two tiny things in the first chapter that I think could be modified.

unc0ver, chimera and electra (devices not using the procursus bootstrap) procursus based jailbreaks (odyssey, odysseyra1n)

You could change the IP address to localhost like in the checkra1n section.

Connecting from a laptop over wifi and Using ssh over usb

You should maybe tell the reader to use the port 44 if he uses checkra1n otherwise the ssh connection will fail.

Let me know what you think of it :) Have a nice day!

demhademha commented 3 years ago

I'll fix that soon hopefully Thanks for spotting that.

raspberryenvoie commented 3 years ago

Cool!

demhademha commented 3 years ago

Fixed in https://github.com/demhademha/tweak-development-guide/commit/49f730ab7b462fcf871a0a63004cc6f0d7264a69 Tell me if this is ready to close :)

raspberryenvoie commented 3 years ago

You forgot some small things, I made a new pull request https://github.com/demhademha/tweak-development-guide/pull/5 Let me know if it's okay

demhademha commented 3 years ago

Fixed in https://github.com/demhademha/tweak-development-guide/commit/24edaa2015b77d7cb7e7995b78908e1144f32be6 I'll leave this open for a bit in case you want to add anything.

raspberryenvoie commented 3 years ago

Okay, thanks, at the moment, I don't need to add anything

demhademha commented 3 years ago

Thank you for your contribution

raspberryenvoie commented 3 years ago

Np! I like the idea of this project, I’m sure this guide will help many people

demhademha commented 3 years ago

Well, if you want to be a editor send me a DM ;)