search

demiangomez / Parallel.GAMIT

Python wrapper to parallelize GAMIT executions
BSD 3-Clause "New" or "Revised" License
36 stars 18 forks source link

Submit a record with empty date end is filled automatically #77

Closed marafigue closed 1 month ago

marafigue commented 1 month ago

When you submit an Information record with empty "DATE END", it automatically fills the date with some date in the future:

image

image

demiangomez commented 1 month ago

This is really dangerous! @marafigue please make sure that all of the station info that you created with this tool have the appropriate date end. If needed, make them NULL using pgAdmin. @Salacas the behavior here should be to allow this field to be NULL. All processes within Parallel.GAMIT assume that a NULL date end means that this station information record is OPEN and, therefore, all new data should have this record applied. Although writing a date in the future accomplishes the same thing, I am not entirely sure what could happen to all the processes that expect to see NULL here.

demiangomez commented 1 month ago

Problem with date persists and now shows other issues:

NULL date represented as 1970. This example is from RDCM image

Date in DOY format and date picker is not synchronized image image

If you edit a field but escape the window (using the ESC key) the change appears to be applied if you open the edit window again. This actually applies to ALL fields, not just the date. When you click on the X to close, then the information is discarded, or if you load a different record.

Current format is DD/MM/YYYY HH:MM:SS but this is confusing because in English MM/DD/YYYY is expected. Change to YYYY-MM-DD to avoid ambiguities.

francolau commented 1 month ago

If you edit a field but escape the window (using the ESC key) the change appears to be applied if you open the edit window again. This actually applies to ALL fields, not just the date. When you click on the X to close, then the information is discarded, or if you load a different record.

ESC Key never save the information, but we also check why the last value is hold on the form.

francolau commented 1 month ago

If you edit a field but escape the window (using the ESC key) the change appears to be applied if you open the edit window again. This actually applies to ALL fields, not just the date. When you click on the X to close, then the information is discarded, or if you load a different record.

ESC Key never save the information, but we also check why the last value is hold on the form.

Now ESC Key act like cross key on header.