Ignore URL path option is not working as expected

rockeynebhwani commented 4 years ago

Seeing this with load of https://direct.asda.com/george/clothing/10,default,sc.html
- added following in Ignore URL paths setting -
- Closed the browser and opened a fresh instance
- Go to https://direct.asda.com/george/clothing/10,default,sc.html and DevTools shows URLs meeting these patterns fetched by quicklink.umd.js

So not sure if the Ignore URL path setting is really working...

George.com is a SPA (React + WebPack + Workbox)

demianrenzulli commented 4 years ago

Hi @rockeynebhwani! Thanks a lot for filing and sharing these details.

After making some tests, I've found that there might be a bug in the pattern magic logic with the URLs you have entered. Not sure if it's due to the camel case or the "-" character.

For this URL: https://direct.asda.com/on/demandware.store/Sites-ASDA-Site/default/SaveForLater-Show

If, instead of "SaveForLater-Show" you enter "save" it should work as expected.

Please, let us know if it works for you.

We can consider this a bug to be fixed in the next release.

rockeynebhwani commented 4 years ago

Thanks @demianrenzulli . It was not a issue with "-". It was the case.. Changed everything to lower case and it worked

demianrenzulli / quicklink-chrome-extension

Ignore URL path option is not working as expected #5