search

demianturner / sgl-docs-tickets-migration-test

0 stars 0 forks source link

In PEAR::DB 1.7.8RC1 new method DB::getDSNString() was introduced #1384

Open demianturner opened 11 years ago

demianturner commented 11 years ago

We can use this native method instead of Seagull's SGLDB::getDSN(SGL*_STRING).

demianturner commented 11 years ago

[lakiboy] Recently PEAR::DB 1.7.8 was released and is required for the following patch.

demianturner commented 11 years ago

[lakiboy] PEAR::DB devs broke BC with their DB 1.7.7 release. We have to quote table name before using DB_mysql#tableInfo().

demianturner commented 11 years ago

[demian] this kills my DB connectivity, i get msg:

{{{ [nativecode=1102 * Incorrect database name ':3306/seagull'] * mysql_SGL(mysql)://root:@unix(localhost):3306/seagull }}}

using latest DB, 1.7.9

demianturner commented 11 years ago

[demian] seems patch works for tcp connections, not unix sockets

demianturner commented 11 years ago

[lakiboy] Correct, works fine on Windows using tcp. Seems there is no chance for me to debug unix sockets i reassign this ticket to anybody.

demianturner commented 11 years ago

[demian] can someone test this with unix sockets, ie on mac or linux

demianturner commented 11 years ago

[aj] Hi guys,

The added patch has been tested using tcp on a remote and local db. I've also updated the unit tests so they work properly.

demianturner commented 11 years ago

[demian] i took too long to apply this :-( we now have quite a few errors in patch:

{{{ Demian-Turners-Laptop:0.6-bugfix demian$ patch -p0 --dry-run < 1384.patch patching file etc/sglBridge.php Hunk #1 succeeded at 49 (offset 2 lines). patching file lib/SGL/DB.php Hunk #1 succeeded at 105 (offset -1 lines). Hunk #2 FAILED at 135. Hunk #3 FAILED at 144. 2 out of 3 hunks FAILED -- saving rejects to file lib/SGL/DB.php.rej patching file lib/SGL/tests/DbTest.wdb.php patching file tests/classes/DB.php Hunk #1 FAILED at 99. 1 out of 1 hunk FAILED -- saving rejects to file tests/classes/DB.php.rej

}}}