search

demianturner / sgl-docs-tickets-migration-test

0 stars 0 forks source link

Several tests bugs #1557

Closed demianturner closed 11 years ago

demianturner commented 11 years ago

I'm trying to solve the Unit Tests problems and looking at this file source:branches/0.6-bugfix/lib/SGL/tests/LocaleTest.wdd.php, I think this test is uncomplete because there isn't any test assertion.

demianturner commented 11 years ago

[ajmixto] I've been working on solve several test problems, and here is a summary of my patches:

'''lib/SGL/tests/LocaleTest.wdd.php''' I've disabled testSingletonWithArg since it doesn't content any assertion so it tests nothing.

'''lib/SGL/tests/VariousTest.ndb.php''' Because previous tests can manipulate the session, we have to ensure that the session role id is SGL_ADMIN before test_hasAdminGui

'''lib/SGL/tests/CssHelperTest.ndb.php''' The file www/themes/helpers.php has been moved to www/themes/csshelpers.php so the require_once fails

'''modules/user/tests/DA_UserTest.wdd.php''' I think the number of perms we are expecting in testGetRemainingPerms is erroneous, but I'm not sure, please check it

'''modules/user/tests/UserMgrTest.wdd.php''' I've added a tearDown method so the usr table and the usr_seq are cleaned after leaving this test

'''lib/pear/File/Archive/Reader/Directory.php''' This file has been patched in order to solve this bug: http://pear.php.net/bugs/bug.php?id=6546 which make FileTest fails

demianturner commented 11 years ago

[demian] Dude - thanks a lot for these fixes, we tweaked things a little, pls close this ticket if you are happy.

demianturner commented 11 years ago

[ajmixto] I'm very happy :)

Great work!