search

demianturner / sgl-docs-tickets-migration-test

0 stars 0 forks source link

change langID #1559

Closed demianturner closed 11 years ago

demianturner commented 11 years ago

In order to use iconv(). The langID of Chinese Traditional in lib/data/ary.languages.php must be changed.

demianturner commented 11 years ago

[demian] Hey Henry - your patches breaks the convention of how all the language codes are formatting, which is probably an ISO convention. I recommend you rather implement:

if $lang == zh* convert_to_iconv_format($lang)

demianturner commented 11 years ago

[henryjuan] Demian, if we don't want to change the langID of zh-tw-*, then we must do array_shift($aLang) one more time in order to get the correct charset which is 'utf-8' in 'zh-tw-utf-8' case and 'big5' in 'zh-tw-big5' case.

demianturner commented 11 years ago

[demian](In [3580]) fixed charset detection for tw, fixes #1559