search

demianturner / sgl-docs-tickets-migration-test

0 stars 0 forks source link

BC patch for SGL_Task_SetupLangSupport to respect translations from default manager #1581

Closed demianturner closed 11 years ago

demianturner commented 11 years ago

Hey,

as suggested via mail. See thread http://groups.google.de/group/seagull_general/browse_thread/thread/dc99c8fcb6af42d6?hl=de

demianturner commented 11 years ago

[demian] Hi Fabio

I would suggest a slightly different approach, that is

  1. add the new key to default.conf.dist.ini
  2. add it to Config template
  3. set the BC option by default
  4. test with !empty() in lib/SGL/Task/Process.php so svn updaters don't get any errors
  5. forget about new install option, this is unnecessary overhead
demianturner commented 11 years ago

[openhaus] Hi Demian,

about 4.: test with !empty() in lib/SGL/Task/Process.php so svn updaters don't get any errors

The only change I would make in lib/SGL/Task/Process.php is this test:

'''if (SGL_Config::get('translation.defaultLangBC')) {'''

If the key does not exist, SGL_Config will return false. SGL_Config does not throw any errors as it tests keys with isset. Would should I test with !empty()?

Ciao Fabio.

demianturner commented 11 years ago

[demian] Hi Fabio - you're absolutely right, I forgot we made this easier to use ;-)

Patch applied - thanks