search

demianturner / sgl-docs-tickets-migration-test

0 stars 0 forks source link

CSS cannot be added by media type #1650

Closed demianturner closed 11 years ago

demianturner commented 11 years ago

Currently all CSS files are included in a page without a media attribute, therefore defaulting to "all". This is undesirable when wanting to use a seagull site on different devices or printing. I've changed SGL_Output::addCssFile to accept $media parameter like so:

{{{ function addCssFile($file, $media = null) }}}

When not specific behaviour is unaffected. Patch attached.

demianturner commented 11 years ago

[demian] Hi codebrewery

Nice patch but in this case we find it adds more code to the fw without greatly enhancing functionality.

We're moving over to yaml CSS framework where you can specify in the css file the media type, ie

{{{ @media print { p { print styles } } }}}

Currently our objective is to reduce core code as much as possible, so on this occasion we can't use your work. thanks anyway and please keep on submitting your ideas.