search

demianturner / sgl-docs-tickets-migration-test

0 stars 0 forks source link

Patch to replace all remaining split calls with preg_split #1745

Closed demianturner closed 11 years ago

demianturner commented 11 years ago

Patch to replace all remaining split calls with preg_split as discussed in http://groups.google.de/group/seagull_general/browse_thread/thread/aac42d9273379d2c

demianturner commented 11 years ago

[demian] thanks dude, but is this again bugfix? It needs to be against trunk. I removed all files/modules that don't exist, and still got fails:

{{{ demians-mbp:trunk demian$ patch -p0 --dry-run < split_removal.patch patching file lib/SGL/Config.php Hunk #1 FAILED at 149. Hunk #2 FAILED at 455. 2 out of 2 hunks FAILED -- saving rejects to file lib/SGL/Config.php.rej patching file modules/navigation/classes/NavigationDAO.php Hunk #1 succeeded at 218 (offset 1 line). Hunk #2 succeeded at 546 (offset 1 line). Hunk #3 FAILED at 627. 1 out of 3 hunks FAILED -- saving rejects to file modules/navigation/classes/NavigationDAO.php.rej patching file modules/navigation/classes/SimpleDriver.php patching file modules/user/classes/RoleMgr.php

}}}

demianturner commented 11 years ago

[openhaus] Yes, that patch was against bugfix. Apply it there.

demianturner commented 11 years ago

[openhaus] There you go. The patch file for trunk. Cheers.

demianturner commented 11 years ago

[demian] nice one dude, thanks.