search

demianturner / sgl-docs-tickets-migration-test

0 stars 0 forks source link

patch installer for PHP 5.4 #1765

Closed demianturner closed 11 years ago

demianturner commented 11 years ago

Since version of PHP 5.4, the installer will not show up. We have found two bugs need to be fixed:

  1. Line 140 of /lib/pear/HTML/QuickForm/Controller.php The variable assignment statements must do independently: $this->_actionName = $this->getActionName(); list($page, $action) = $this->_actionName;
  2. Line 71 of /lib/SGL/DB.php When $dsn is a string not an array, empty($dsn['phptype']) return true since PHP version 5.4. So the condition must more specifically: if (is_array($dsn) && empty($dsn['phptype']))
demianturner commented 11 years ago

[demian](In [4424]) updates for php 5.4, fixes #1765

demianturner commented 11 years ago

[demian](In [4425]) updates for php 5.4, fixes #1765 -1

demianturner commented 11 years ago

[demian] Thanks for this Henry