demianw / tract_querier

Implementation of the White Matter Query Language and associated tools for dMRI white matter tract extraction and analysis
Other
27 stars 27 forks source link

FIX: find_queries_path() now explores all sysconfig schemes #40

Closed emanuele closed 7 years ago

emanuele commented 7 years ago

When installing tract_querier in non-system folders, e.g. with python setup.py install --user, tract_querier is unable to find the queries and triggers Exception: Default path for queries not found and immediately stop working. The issue is in find_queries_path(), where sysconfig.get_path() uses only the default scheme, see: https://docs.python.org/3/library/sysconfig.html#installation-paths. This patch fixes the issue by looping through all schemes supported by Python. See issue #39.

emanuele commented 7 years ago

Hi, I see Travis CI failed. As far as I understand the problem is unrelated to my patch.

demianw commented 7 years ago

H! Thanks for this, will check it later today

demianw commented 7 years ago

@emanuele I fixed the travis error. Had to do with their change of pyenv version. Could you try to rebase and check if it still fails?

emanuele commented 7 years ago

Done. Unfortunately, AppVeyor build failed again. But it seems unrelated to my patch.

demianw commented 7 years ago

@emanuele yes it's unrelated! Merged! Thanks!