search

demike / TsUML2

Generates UML diagrams from TypeScript source code
MIT License
266 stars 34 forks source link

Different `typescript` module from dependency of your dependency uncompatible with original `typescript` #84

Closed phpcoder2022 closed 4 months ago

phpcoder2022 commented 4 months ago

Versions:

To Reproduce

  1. Parse any typescript class contains properties with modifier.
  2. Call getCombinedModifierFlags(node) from you typescript file and original typescript module.
  3. See that results are different.

Expected behavior

Its are equal.

Author of ts-morphs responsed me that this error is your.

demike commented 4 months ago

@phpcoder2022 could you provide a minimal reproduction for the faulty behaviour?

phpcoder2022 commented 4 months ago

I created repo for this

demike commented 4 months ago

@phpcoder2022 I really did an import of ModifierFlags directly from "typescript". @dsherret thanks for the clarification. I will switch to the version of ts-morph to completely remove the runtime dependency on typescript.

demike commented 4 months ago

@phpcoder2022 should be fixed 0.17.0

phpcoder2022 commented 4 months ago

Thanks. This case works fine.