search

demikl / python-teleinfo

Read and parse teleinfo data from France EDF electricity provider
MIT License
6 stars 11 forks source link

Added PITInfo #3

Closed hallard closed 4 years ago

hallard commented 4 years ago

I've Added PITinfo but as I'm noob in python and class that's the best I can do

I'd like to add (a fix) for UTInfo2, you hard coded the path with serial number, as UTInfo2 board as unique serial number this will works only with your module, so I think the best is to set port as parameter so we can use /dev/ttyUSB1 or whatever.

Also I would like to add another parameter to handle Linky Standard Mode (9600bps)

Do you think you can handle these parameters or help me do do that I'm lost with class and way to pass parameters ?

Thanks

demikl commented 4 years ago

Hello, thanks for contributing. I'm not sure I can give some time to this project for the suggestions you mentioned. I'll let you know later.

hallard commented 4 years ago

No problem, I can live like that.

BTW, any chance to merge this PR ?

Thanks.

demikl commented 4 years ago

About your request for change on UTInfo2 and upper baudrate, this is already configurable, maybe you're asking about changing the default values ? I had not noticed that the hardcoded TTY device for the UTInfo2 board has a specific ID in it when I accepted the pull request #1 that introduced it.

from teleinfo import Parser
from teleinfo.hw_vendors import UTInfo2
ti = Parser(UTInfo2(port="/dev/ttyAMA0", baudrate=9600))
print ti.get_frame()
hallard commented 4 years ago

That's done

ahah, so simple to change speed and port, I'm a "grosse quiche" in python

I added 2 examples on readme

thanks