demilich1 / metastone

Hearthstone simulator written in Java with full GUI support
GNU General Public License v2.0
132 stars 80 forks source link

Several Issues #280

Closed DominusMaximus closed 7 years ago

DominusMaximus commented 7 years ago
webadict commented 7 years ago

Omg... How did I break everything already?

Alright, working on it.

Also, it is Doppelgangster. It derives from the word doppelganger, which, while looking weird, is correct. Blame the Deutschen background of the word für das.

webadict commented 7 years ago
  1. Fixed the mana issue. I made a mistake while creating vastly superior bug tracking.
  2. Uh... Wow, this one is actually a two parter. So, apparently, this is currently incorrectly setup. Right now, it's working with the TragetAcquisitionPhase, which means that it has the potential to copy spells that were not targeting correctly. This WASN'T the issue, though. The issue is that the source player and the target player were being set to the same person. But guess what? I'm amazing, so it works perfectly now. I've moved the trigger to the AfterSpellCastedTrigger... But I also had to move a few things around so that I could actually do that. As far as I'm aware, I've solved everything. Which means I've inevitably broken something else. And two other things.
  3. I can't actually get this one to happen...? Perhaps you had a Gadgetzhan Auctioneer that drew you a card before you received Excess Mana (Which would be the correct ordering.) That's my only guess.
  4. Dopplegangster is a dumb name that makes no sense. Someone should be fired for that. The word is DOPPELGANGER! Who do I blame for this?!?
  5. Fixed. Gave the Warriors more weapons.
  6. ... Uh... I actually don't know how that happened. Oh well, fixed.
  7. 2? I think?!? I don't even know, man! But apparently, there was some sort of issue where it only counted minions that were currently being summoned. Which is fixed now. The REAL issue was that it wasn't targeting a weapon when it was buffing. Whooooooops.

TL;DR: Fixed, because I'm amazing.

DominusMaximus commented 7 years ago

That was some quick fixin. Nice.

webadict commented 7 years ago

To be fair, it's easy to fix when you know what to look for. Keep finding those bugs to crush.