search

demilich1 / metastone

Hearthstone simulator written in Java with full GUI support
GNU General Public License v2.0
132 stars 80 forks source link

Knife Juggler, Imp Gang Boss, and Grim Patron Interaction. #342

Open ikhaliq15 opened 7 years ago

ikhaliq15 commented 7 years ago

So according to the Advanced rulebook, the follow interaction should leave you with no grim patron. screen shot 2017-04-19 at 12 01 17 am

However, when I ran it in the Metastone game, I was left with a grim patron remaining. I did everything according to how it says and you can watch a video of the whole interaction here.

I start with: screen shot 2017-04-19 at 12 35 19 am

and end with:

screen shot 2017-04-19 at 7 23 19 am

I don't know if this interaction is to specific to care about, but just thought I would write about it here.

webadict commented 7 years ago

You are correct. I actually saw this a long time ago, but never got around to fixing it. I know exactly what needs to be changed for this, but it's a bit of work, so I'll probably push it a while back.

webadict commented 7 years ago

To be clear, this is an issue with the attack function. The damage events that happen need to be done in a specific order, but the DAMAGE needs to be applied first, which is the issue.

doctorpangloss commented 7 years ago

@webadict described the issue accurately and this is now fixed in my fork.