search

demilich1 / metastone

Hearthstone simulator written in Java with full GUI support
GNU General Public License v2.0
132 stars 80 forks source link

Fix montecarlo behaviour #344

Closed dhokas closed 7 years ago

dhokas commented 7 years ago

The old montecarlo didn't simulate each game from the current turn to the end of the game but only to the end of the current turn.

demilich1 commented 7 years ago

First of all, thanks for your PR!

Did you try out the MonteCarloBehaviour? I tried it a long time ago, but it was slow and came up with very sub-optimal plays. It this is still the case, I don't think it makes sense to expose it as a selectable option for users. What is your take on that?

dhokas commented 7 years ago

Yes it slow and not very good but I'm using Monte Carlo based methods to develop AI, so yes, it isn't very useful to expose it as a selectable option. But it needed to be fixed.

demilich1 commented 7 years ago

I will merge it, but maybe remove the FlatMonteCarlo behaviour as a selectable option for the user later on. Thanks!