demirhanaydin / node-mi-flora

Node package for Xiaomi Mi Flora Plant Sensor
53 stars 21 forks source link

Pass config object #9

Open webnator opened 6 years ago

webnator commented 6 years ago

I've recently began using your library and I think it's really great. For some reason, my device has a different name than the one that defaults in the library, so I thought it'd be cool if I was able to change via config params these default settings, so I made it. If you feel that these could be useful, go ahead and merge it in your project.

demirhanaydin commented 6 years ago

Thanks for the pr @webnator. I'll go through it when I get my new flora to test it. Also I gotta need to create a test coverage for the package as well.

webnator commented 6 years ago

Awesome! I didn't see the tests in the repo, but if you need help testing, let me know. I usually use jest, and it works really good. See you