search

demisjohn / CAMFR

Python-based electromagnetic simulator and mode solver for nanophotonics applications, using the Eigenmode Expansion (EME) method.
GNU General Public License v2.0
65 stars 30 forks source link

camfr_PIL.py #1

Closed kitchenknif closed 6 years ago

kitchenknif commented 8 years ago

Several uses of numpy.oldnumeric.mlab

demisjohn commented 6 years ago

Looks like this fork has attempted to fix this: https://github.com/jtambasco/camfr/commit/78f92f1acd09a40ffc9b800d15721989714d218f maybe see if a Pull Request is in order.

demisjohn commented 6 years ago

I've also fixed this, but by upgrading to PILLOW instead of using the defunct PIL. https://github.com/demisjohn/CAMFR/commit/a138e8ee793fb4d7c79c4da9cd85a5b24e223a5b Let me know if you'd like me to submit a pull request. Since you last worked on this repo 2 years ago, I assume I should just keep working on my fork (I have immediate use for it), and not submit a pull request.

kitchenknif commented 6 years ago

Yeah, I don't have an immediate use for CAMFR at the moment, my work has steered away from it.

demisjohn commented 6 years ago

fixed in a138e8ee793fb4d7c79c4da9cd85a5b24e223a5b, upgraded to use PILLOW since PIL is deprecated. Eventually will just use Matplotlib for everything anyway.