search

demisjohn / CAMFR

Python-based electromagnetic simulator and mode solver for nanophotonics applications, using the Eigenmode Expansion (EME) method.
GNU General Public License v2.0
65 stars 30 forks source link

Merge demisjohn fork/transfer ownership #3

Closed demisjohn closed 6 years ago

demisjohn commented 6 years ago

Hello,

I was wondering if I could somehow take over ownership of this repo, and just add you as a maintainer. Not sure of the exact logistics of that, but I assume it's possible somehow. Happy to add anyone as collaborators, but I will actually take the time to look at pull requests etc.

GitHub looks like a perfect place to continue development and post upgrades to CAMFR, continuing it's excellent utility. Although I'm not particularly great at coding up mathematical models, I will try to upgrade the package to keep it current (currently working on Python3 upgrade). Maybe the community can help with actual modeling coding.

Let me know what you think. -- Demis

kitchenknif commented 6 years ago

Hey, Don't see any problem with that, seems like the correct way forward, since I'm not currently working on the project.

kitchenknif commented 6 years ago

If I understand this correctly, https://help.github.com/articles/about-repository-transfers/ , For me to transfer ownership to you, you would first have to delete your fork. So I guess you could do a pull request of all of your commits to this repository, then delete your fork and then I will transfer ownership.

demisjohn commented 6 years ago

Ok, I will mostly overwrite all your changes with mine. Will submit the PR for brach master now.

Following these instructions to transfer the py35_compat branch: https://stackoverflow.com/a/5884825/2453202 Also will find some way to transfer Issues, in which I've tried to document much of the work.

By the way, thanks for creating the GitHub repo from SourceForge in the first place, that was a great move.

-- Demis -- °•Oo.oO•°°•Oo. Sound OK http://www.google.com/search?q=sound+ok+horn&tbm=isch Horn °•Oo.oO•°*°•O o.

On Tue, Apr 10, 2018 at 12:12 AM, Pavel Dmitriev notifications@github.com wrote:

If I understand this correctly, https://help.github.com/ articles/about-repository-transfers/ , For me to transfer ownership to you, you would first have to delete your fork. So I guess you could do a pull request of all of your commits to this repository, then delete your fork and then I will transfer ownership.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kitchenknif/CAMFR/issues/3#issuecomment-379998145, or mute the thread https://github.com/notifications/unsubscribe-auth/AFHxRSQ8yWX73kklMgDtpVinT0yKsD7kks5tnFtogaJpZM4TDJBy .

kitchenknif commented 6 years ago

I'll transfer ownership once you move everything to this repo, cannot while your fork still exists.

demisjohn commented 6 years ago

I've transferred all issues, and Deleted my repo! Go ahead and do the transfer.

Thanks!

kitchenknif commented 6 years ago

Done, Thanks for stepping up to maintain this project!