search

demisto / content-docs

Demisto Content Developer Docs
https://xsoar.pan.dev/
MIT License
41 stars 56 forks source link

Issue with "Check Point Firewall v2" in @site/docs/reference/integrations/check-point-firewall-v2.md #394

Closed FFrozTT closed 3 years ago

FFrozTT commented 3 years ago

In it's current state it may work well for connecting to a standalone management server however connecting to an MDS ("Multi Domain Server") will require the parameter Domain to be included in the JSON body of the checkpoint_login_and_get_sid_command function. So instead of this:

{
    "user":"<Username>",
    "password":"<Password>"
}

it will need this:

{
    "user":"<Username>",
    "password":"<Password>",
    "domain" : "<CMA Domain>"
}

Of course I'm trying to connect to my MDS so I really need this domain parameter mapped. It probably makes the most sense to create a new function for this, something like checkpoint_mds_login_and_get_sid_command which has the domain parameter as a required string.

https://sc1.checkpoint.com/documents/latest/APIs/#web/login~v1.7%20

Thanks!

Screenshots

Environment

Suggested fix

welcome[bot] commented 3 years ago

Hi and welcome to our Content Developer Docs project! Thanks and congrats for opening your very first issue. If you know the fix, you may also submit a PR to fix the issue if you like!

FFrozTT commented 3 years ago

PR #10196 submitted for review

glicht commented 3 years ago

@FFrozTT thanks for reporting this. I see you opened a PR. Your contribution is appreciated. The team will review the PR and get back to you soon.

glicht commented 3 years ago

Relevant pr: https://github.com/demisto/content/pull/10356