When generating a report with a markdown table with a lot of rows had an issue that some of the rows were hidden.
It also reproduces before this change: https://github.com/demisto/sane-reports/pull/259.
Because of this change now more data is visible.
Also there is now a small margin between the evidences.
Description
This PR is fixing issue with tables are not displaying their whole rows.
And an issue that we had overlapping sections.
Implementation details
It was added so sections in a grid will take the whole height so the borders will look well.
It was added to evidence row (or similar items) will look like this:
When there is one item inside the flex is not needed.
QA
Generated Report
investigationSummaryReport_1703159885621320074.json
Before
investigationSummaryReport_1703159885621320074.pdf
After
investigationSummaryReport_1703159885621320074_after.pdf
Comparing notes
When generating a report with a markdown table with a lot of rows had an issue that some of the rows were hidden. It also reproduces before this change: https://github.com/demisto/sane-reports/pull/259.
Because of this change now more data is visible. Also there is now a small margin between the evidences.
Generated Report
176b15de-9301-4f76-8e81-fad81bfb7bfc_1703157199715137908.json
Before
176b15de-9301-4f76-8e81-fad81bfb7bfc_1703157199715137908.pdf
After
176b15de-9301-4f76-8e81-fad81bfb7bfc_1703157199715137908_after.pdf
Comparing notes
Looks the same.
Also tested on A3 and it still looks well (not like described in the issue): 176b15de-9301-4f76-8e81-fad81bfb7bfc_1703157199715137908_after_A3.pdf
Generated Report
investigationSummaryReport_1704119961501017000.json
Before
investigationSummaryReport_1704119961501017000_before.pdf
After
investigationSummaryReport_1704119961501017000_after.pdf
Comparing notes
Looks the same.
I noticed a potential bug that markdown fields are not displayed as a markdown. Validated that it also looked like this before the changes in https://github.com/demisto/sane-reports/pull/249.
Generated Report
testLayoutIncidenInfo.json
Before
testLayoutIncidenInfo_before.pdf
After
testLayoutIncidenInfo_after.pdf
Comparing notes
Looks the same.
Generated Report
CRTX-96742.json
Before
CRTX-96742_before.pdf
After
CRTX-96742_after.pdf
Comparing notes
An overlapping issue was fixed
Generated Report
genTempCPUBug.json
Before
genTempCPUBug_before.pdf
After
genTempCPUBug_after.pdf
Comparing notes
Looks the same.
Generated Report
investigationSummaryReport_1704192927372821424.json
Before
investigationSummaryReport_1704192927372821424_before.pdf
After
investigationSummaryReport_1704192927372821424_after.pdf
Comparing notes
An overlapping issue was fixed