demntor / pymodbus

Modbus Python release (tools included)
0 stars 0 forks source link

Problem with WriteMultipleCoilsRequest #33

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi!

It looks as if WriteMultipleCoilsRequest does not work as expected
when used in the context of a ServerEncoding.

In the constructor, a ParameterException is raised if the values
parameter is not given. But when a WriteMultipleCoilsRequest is
created by the ServerDecoder (in the _helper method), it is _always_
instantiated without parameters!

Commenting out the line which raises the ParameterException seems
to help. But I'm not sure if there are valid cases where this
exception should be raised...

BTW: The code for writing multiple holding registers is very
similar - I think it has the same problem.

Please have a look.

Thanks, 

Albert

Original issue reported on code.google.com by albert.k...@gmail.com on 7 Feb 2011 at 11:45

GoogleCodeExporter commented 8 years ago
Yes you are correct, I forgot about the factory decoders when I was fixing 
these requests.  Give me a moment and I will have them back in shape.  Thanks 
again Albert.

Original comment by Bashw...@gmail.com on 7 Feb 2011 at 4:16

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r101.

Original comment by Bashw...@gmail.com on 7 Feb 2011 at 4:20