cloning instrument causes system hang

democloid / picoTracker

BSD 3-Clause "New" or "Revised" License

187 stars 17 forks source link

cloning instrument causes system hang #176

Closed djdiskmachine closed 3 months ago

djdiskmachine commented 3 months ago

Steps to reproduce:

Go to Phrase View.
Create a new sample instrument.
Navigate to the instrument column.
Use the clone command (L+B, A).

Expected: New instrument created with identical properties.

Result: System requires a hard reset.

Reocurrance: Always

Commit: d1d4070

djdiskmachine commented 3 months ago

Something strange happens after InstrumentBank::Clone, line 256 That's as far as i managed to get 😅 It never returns anything valid and just hangs. More digging tomorrow

maks commented 3 months ago

Thanks for spotting this! I wonder why the change I did for the Midi VEL cmd caused this to break. Anyways thanks for reporting this, I can have a look at it later in the week if you don't get to it first 🙂

djdiskmachine commented 3 months ago

It's actually introduced in this commit ec1a84b4b46 I discovered the issue on d1d4070

djdiskmachine commented 3 months ago

Fixed in https://github.com/djdiskmachine/picoTracker/commit/a0ce662404047c28b1b613e731aa254529ff34af

maks commented 3 months ago

Ah nice work @djdiskmachine ! 👍🏻 Did you want to do a PR with that commit to this repo?

djdiskmachine commented 3 months ago

@maks done! https://github.com/democloid/picoTracker/pull/177