search

democloid / picoTracker

BSD 3-Clause "New" or "Revised" License
187 stars 17 forks source link

Use a different colour for 00, FF chains #181

Open maks opened 3 months ago

maks commented 3 months ago

Some users of picoTracker as well as LGPT (and M8) use the convention of having empty chains as 00 or FF so its helpful if these can be displayed in a different colour.

This colour should also be user configurable, for now via config.xml.

maks commented 3 months ago

This could also include a separate colour for FE which I think is also commonly used as a kill all chain.

democloid commented 3 months ago

Wonder if it would be quick enough to calculate this on the fly and mark on a certain color any empty chains.

maks commented 3 months ago

@democloid yes I think we could do that, but if prefer to save cpu cycles on this for other things as it's just a cosmetic and would a small, light touch change just to do it for a few specific chain numbers.

RAWJUNGLE commented 2 months ago

This could also include a separate colour for FE which I think is also commonly used as a kill all chain.

FE is not used as Kill All chain and etc.

It would be better not to highlight empty chains.

In those chains where there are no notes in the phrase (but there are commands like kil) do not make white, but highlight gray (for example) as inactive.

maks commented 2 months ago

@RAWJUNGLE Thanks for the feedback but would you like to provide more details on your statement of:

FE is not used as Kill All chain and etc.

as I my understanding is that someone people do use that as the convention.

And I'll just take:

It would be better not to highlight empty chains.

as your personal preference. Given that the colours for this functionality like all the other colours would be user configurable anyone who didn't want to have these specific chains highlighted could simply choose to use the same colour as used for all other chains.

maks commented 1 week ago

At a minimum will support the set of colours already added to @djdiskmachine LGPT fork

djdiskmachine commented 2 days ago

FE vs 00 is like discussing tab vs double space in programming. Don't go there ;)