search

democracyworks / datomic-toolbox

Datomic Utility Library
19 stars 0 forks source link

[CS] Support schema files within JARs #4

Closed tie-rack closed 9 years ago

tie-rack commented 9 years ago

Schema resources were assumed to always be accessible via the filesystem, causing schema-files to complain that the found "files" were "not files". See this discussion for some detail.

We now explicitly handle the case where the schema files are trapped in a jar, allowing uberjarred projects to use this library.

cap10morgan commented 9 years ago

This seems like a lot of code for a problem that Clojure itself or at least a library should already have solved, but I trust you did your homework there. So LGTM.

tie-rack commented 9 years ago

There's not even a Java library (AFAICT). This seems typically solved with a "manifest" file at a known location that has full resource paths to the files in question. Perhaps that's where we'll have to go.