search

democritus-project / d8s-strings

Democritus functions for working with Python strings.
GNU Lesser General Public License v3.0
1 stars 2 forks source link

Consider integrating with https://pypi.org/project/stringcontext/ #8

Closed fhightower closed 3 years ago

fhightower commented 3 years ago

WHAT I want this project to do (or not do)

Integrate with https://pypi.org/project/stringcontext/

WHY I want this project to have this feature

To improve our ability to view a string in context.

raprocks commented 3 years ago

Will it be okay to add this functionality as a function? this fairly simple to implement if we take care of the edge cases like if the context before and after is out of range such that the string is smaller and so others

fhightower commented 3 years ago

Hi @raprocks ! Thanks for asking. This issue was an old one that I moved from another place. I don't think we should work on it as the stringcontext library looks pretty solid on its own and we don't want to duplicate functionality or needlessly wrap functions.

This is part of a larger discussion on what this library is (which is something I'm still thinking about and scoping), but in the past I have made the mistake of replicating other libraries or needlessly wrapping functions (there is an example that still exists here). If there is already a decent library to do something and there are no ways we can make the interface or functionality better, I'd say we shouldn't do anything. As such, I think we should close this issue and label it wontfix.

Thoughts?

raprocks commented 3 years ago

I second that, it's no use replicating something and wasting our time.

On Tue, Jun 8, 2021, 5:09 PM Floyd Hightower @.***> wrote:

Hi @raprocks https://github.com/raprocks ! Thanks for asking. This issue was an old one that I moved from another place. I don't think we should work on it as the stringcontext https://pypi.org/project/stringcontext/ library looks pretty solid on its own and we don't want to duplicate functionality or needlessly wrap functions.

This is part of a larger discussion on what this library is (which is something I'm still thinking about and scoping), but in the past I have made the mistake of replicating other libraries or needlessly wrapping functions (there is an example that still exists here https://github.com/democritus-project/d8s-strings/blob/cd74ba0b7fa0fcb27d3da71a7a1bc95f98f0608d/d8s_strings/strings.py#L459). If there is already a decent library to do something and there are no ways we can make the interface or functionality better, I'd say we shouldn't do anything. As such, I think we should close this issue and label it wontfix .

Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/democritus-project/d8s-strings/issues/8#issuecomment-856689801, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUEXQF7JKGCJ2FK2S337W3TRX6PVANCNFSM4YIH6HOA .

fhightower commented 3 years ago

Sounds good. I'll close this one out.