demonrain / workspacemechanic

Automatically exported from code.google.com/p/workspacemechanic
0 stars 0 forks source link

Keyboard shortcut tasks all share the same Ids preventing useful task blocking #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently all keyboard shortcut tasks have the id: 
com.google.eclipse.mechanic.core.keybinding.KeyboardBindingsTask

KBT extends CompositeTask which defaults to just the class name.

This makes it difficult to use more than one keyboard binding task as the 
blocked task mechanism works off of assuming unique IDs.  If this is violated, 
then you cannot block particular KBTs and keep others.

It seems reasonable to implement a scheme similar to 
LastModifiedPreferencesFileTask where the resource path is appended to the 
class name.

I'll submit a patch for this here in a few mins.

Original issue reported on code.google.com by stevemash on 10 Dec 2011 at 4:28

GoogleCodeExporter commented 9 years ago
Patch submitted and review opened: 
http://code.google.com/a/eclipselabs.org/p/workspacemechanic/issues/detail?id=84

Original comment by stevemash on 10 Dec 2011 at 4:55

GoogleCodeExporter commented 9 years ago
Z, please take a look at this.

Original comment by konigsb...@gmail.com on 18 Dec 2011 at 7:10

GoogleCodeExporter commented 9 years ago

Original comment by konigsb...@gmail.com on 24 Jun 2012 at 3:36