With patch: key bindings with params, when dumped, don't get the params dumped

[GoogleCodeExporter]

Robert, please review this change.

****************************************

What steps will reproduce the problem?

1. create a key binding with params (say, "Show View: Display")
2. dump it
3. look at the dump -- it does not contain the "params" part

The patch below fixes my code. The fix itself is trivial, just the one line on 
EclBinding to pass "params" to KbaBinding constructor. But I feel that the 
constructor that doesn't take params is kind of bogus and misleading, so I also 
remove it, and percolate that change through the code. I also noticed that my 
tests on round trip did not assert as I feel they should, so I added assertions.

To restate: everything was already working, except the EclBinding thing. All 
other changes are opportunistic.

Original issue reported on code.google.com by zorze...@gmail.com on 7 May 2012 at 4:19

Attachments:

• KEYBINDINGS.PATCH

[GoogleCodeExporter]

Thanks. Applied. 

Original comment by konigsb...@gmail.com on 23 Jun 2012 at 1:49

• Changed state: Fixed