search

demoscene-rs / rust-rocket

gnu rocket client library in rust
MIT License
20 stars 7 forks source link

Panicking instead of returning RocketErr #2

Closed tanis2000 closed 5 years ago

tanis2000 commented 6 years ago

Is it just me or lines like this one https://github.com/Darksecond/rust-rocket/blob/master/src/client.rs#L92 actually panic instead of throwing back a RocketErr?

Darksecond commented 6 years ago

yes, it can probably be replaced with a map_err and a ?. I would welcome a pull request very much, otherwise I might work on it over the weekend

Darksecond commented 5 years ago

It can still be better, but at least it does not panic anymore in connect.