search

demoscene-rs / rust-rocket

gnu rocket client library in rust
MIT License
20 stars 7 forks source link

Add a Player #7

Closed gustafla closed 3 years ago

gustafla commented 3 years ago

I hacked together a player and save_tracks -functionality with serde and bincode. Seems to work on my machine :tm:. Improvement suggestions are welcome, and you can refuse to merge if you see any issues. I know the player's use of HashMap is a bit questionable, I really should profile it but I have a demo to make :man_shrugging:. Kind of unsuitable for 4ks and the like because of dependencies on std and error handling bloat :D Thanks and have a nice week

Darksecond commented 3 years ago

There are a few small things I'm not sure about and could be thought over. In general I do like the idea of adding playing abilities. We rely on std anyways, so it was never designed to be used in a 64k/4k demo directly, if we do want to have that ability it might be profitable to seperate out the player into a seperate crate.

Seperate from this, how do you feel about getting direct commit access, you've been merging more code than I have lately and you obviously like this crate :)

gustafla commented 3 years ago

Thanks for the feedback. Yeah direct commit access would be appreciated, I plan to use this crate for a while because I'm not yet ready to develop my own demotool.