search

demozoo / cowbell

A universal web audio player for demoscene / tracker music
https://demozoo.github.io/cowbell/
BSD 3-Clause "New" or "Revised" License
75 stars 6 forks source link

Update ASAP to 6.0.1 #34

Closed pfusik closed 10 months ago

pfusik commented 1 year ago

Fixes #22

pfusik commented 10 months ago

@gasman Could you please merge this?

gasman commented 10 months ago

@pfusik Sorry for the delay! Looking into this now.

I'd like to avoid making any changes to the output filenames / <script> includes if possible, so that this can be a drop-in replacement for older versions. Currently investigating whether we can use babel-minify as a replacement for closure-compiler - hopefully that should have better support for new JS features, as well as eliminating an old crufty Java dependency...

gasman commented 10 months ago

Success! Revised version merged in https://github.com/demozoo/cowbell/commit/78d6dcc2b65b5ebbe2677cc06eabf47d70e1a47b.

(In addition to changing the build command, I had to edit out the exports from asap.js to make it work in the old-style concatenate-all-the-files approach. In retrospect, I could probably have just got minify to follow the import in your version of asap-player.js for exactly the same result. But why fix what isn't broken... :-) )