demozoo / demozoo

the best demoscene website in the world.
111 stars 29 forks source link

Animated GIF screenshots are corrupted #44

Open gasman opened 10 years ago

gasman commented 10 years ago

http://demozoo.org/graphics/17414/ - presumably the uploaded version of the image had a border on the first frame, and no border on the second (so it got shifted up/left, leaving some junk bytes behind)

It's debatable whether we should allow animated GIF screenshots - Spectrum screenshots using the 'flash' attribute are one place where it's appropriate to use them. Graphics compos that specifically permit animated GIF entries might be another (no, animated GIFs can be 10s of megabytes in size; we should be taking screenshots OF them, not treating them AS screenshots)... other times we could probably assume it's a Pouet-style slideshow and should be split into separate screens. Either way, we should either cleanly accept or reject them, not fall over at the processing stage.

gasman commented 6 years ago

Discussed on Slack today - we've agreed that the preferred behaviour is to discard everything but the first frame of animations. Uploading an animation as a screenshot is wrong more often than it's right, and the cases where it's arguably valid (Spectrum FLASH attributes and teletext) are obscure enough that we can sensibly reject them. :-)